# Checkpoint 258 — BE-034 financial proposal approval PDF

**Date:** 2026-10-26  
**Story status:** PARTIAL  
**Traceability:** 17 DONE, 120 PARTIAL, 17 MISSING, 10 BLOCKED (164 stories; DONE is 10.4%).

React Sales can save and reopen a private approval PDF for a pending BE-032 financial proposal. Odoo binds the immutable preview to the confirmed sale order, proposal revision, company, creator, timestamp and checksum. The BFF checks active company scope, safe filename, content signature and size. Creating or downloading a preview does not approve/send the proposal or mutate the order.

## Verification

- Backend routes: 2 passed.
- React unit suite: 80 passed; focused Playwright flow: 1 passed; Vite production build passed.
- Native Odoo lifecycle/security/QWeb tests: 3 passed; full isolated Odoo regression: **367 passed, 0 failed, 0 errors**.
- Synthetic Odoo render: valid 22,857-byte one-page A4 PDF; extracted text includes the proposal and SAR 2,875 total; source order remained confirmed and unchanged. The synthetic transaction was rolled back.
- The database-only clone did not contain the source PDF asset filestore. Its report CSS asset request returned 404; inline styles still yielded a one-page PDF. Normal-database visual styling is unverified.

## Local demo rollout

- Before upgrading the shared demo database, saved `/tmp/namaa_ksa_before_be034_20261026.dump` (10,825,862 bytes, mode 0600).
- Upgraded `namaa_ai_bridge` on `namaa_ksa` to **20.0.1.0.26** and rebuilt/restarted the React and BFF containers.
- Smoke checks returned HTTP 200 for React `/`, `/demo.html`, BFF `/api/health/live`, and Odoo `/web/login?db=namaa_ksa`. Database registry confirms the addon is installed at 20.0.1.0.26.
- The local `/demo.html` and public `https://namaa-react-ksa.ngrok-free.app/demo.html` both serve Checkpoint 258 and the current 164-story totals.

## Remaining acceptance

Live two-role React workflow, broader role/company/project authorization matrix, Arabic visual review, rendered styling from a normal populated filestore, and full A1–A4 acceptance remain open. Therefore BE-034 is PARTIAL, not DONE.

See [QA evidence](SALES_FINANCIAL_PROPOSAL_PDF_QA.json), [test results](../TEST_RESULTS.md), and [story matrix](../REQUIREMENTS_TRACEABILITY.md).
