{
  "checkpoint": 259,
  "story": "BE-035",
  "status": "PARTIAL",
  "date": "2026-10-26",
  "native_tests": "7 focused tests passed; complete isolated Odoo regression 371 passed, 0 failed, 0 errors",
  "backend_tests": "236 passed, 2 skipped; 265 subtests",
  "react_unit_tests": "80 passed",
  "react_browser_tests": "2 focused mocked browser journeys passed",
  "production_build": "passed",
  "verified_actions": [
    "approve for internal release",
    "reject with rationale",
    "request revision as a linked new pending version"
  ],
  "security_checks": [
    "Sales Manager/Owner role",
    "active company and opportunity visibility",
    "no author self-review",
    "source revision freshness",
    "revision citations restricted to original source IDs",
    "immutable reviewer event"
  ],
  "no_side_effects": "No suggestion application, customer send, opportunity mutation, quotation creation or external release",
  "limitations": [
    "The current authenticated live two-user React\u2192BFF\u2192Odoo role journey is still outstanding; new browser journeys use synthetic mocked records.",
    "The current native rerun was blocked by a stale isolated-clone schema before selected tests; prior native 7-test pass is historical, and current strengthened assertions need a current-schema QA database.",
    "Supplied generic AC still call for broad project/company and cross-tenant acceptance; ordinary project-linked review and current live role matrix remain open.",
    "Customer authorization for external proposal release remains a business decision. This workflow grants internal approval only and does not send a proposal.",
    "BE-036 approved PDF archive remains a separate story and was not changed by this work."
  ],
  "evidence_scope": "Isolated synthetic QA; source customer/order records not changed",
  "review_date": "2026-11-05",
  "current_focused_results": {
    "api_tests": {
      "command": "PYTHONPATH=backend .venv/bin/pytest -q backend/tests/test_business.py -k 'crm_technical_proposal_review_contract or crm_technical_proposal_review_route_is_authenticated_and_strict'",
      "result": "2 passed, 247 deselected; 4 validation subtests passed."
    },
    "react_tests": {
      "command": "cd frontend && ./node_modules/.bin/playwright test e2e/business.spec.js --grep 'CRM technical proposal gets an independent|CRM technical proposal rejection records independent|CRM technical proposal revision creates a linked pending'",
      "result": "3 passed. The journeys use synthetic records and mocked API responses."
    },
    "native_tests": {
      "command": "Disposable clone of be_qa_demo_full_20261025; upgrade namaa_ai_bridge and run four selected TestCrmTechnicalProposal approval/rejection/revision/author-separation methods.",
      "result": "Blocked before selected tests: Odoo registry upgrade ran MRP demo scheduler and failed on stale snapshot schema (`purchase_order.namaa_supplier_quote_received_date` missing). Clone DB dropped and cleanup verified; source DB was not modified. Existing prior native result of 7 focused tests remains historical evidence; strengthened current assertions are not yet natively verified."
    },
    "diff_check": "PASS: git diff --check on changed BE-035 source/evidence files."
  },
  "changes_current": [
    "Extended native approve, reject and revise tests to assert company, lead, reviewer, timestamp and rationale on each immutable review event; reject/revise events now also assert write and unlink are blocked.",
    "Added synthetic React rejection journey that verifies required rationale, persisted reviewer/time/rationale display, and no archive/send action.",
    "Added synthetic React revision journey that verifies a linked pending version, preserved source citations, reviewer rationale, and no archive/send action."
  ],
  "conclusion": "Keep BE-035 PARTIAL. Odoo source already supports independent approve/reject/revise, immutable rationale events and role/company boundaries; the current API route/contract tests passed 2/2 and React synthetic approve/reject/revise journeys passed 3/3. Do not count DONE because the current native rerun could not pass the stale clone upgrade, the current browser journeys are mocked, and external customer-release authority plus the supplied project/tenant acceptance remain open."
}
